They went through the full review before merging. I was not asked to fix them, test in another browsers afterwards. No one contacted me. Just deleted a feature that I really wanted to see and decided to create for everyone.
@alxd I'm sorry you had to deal with this. 😔
Did a merge request that would’ve added a guide to adding your own icons & custom CSS using the admin UI. A week later there was no response & no feedback, so closed it.
I do technical writing as my day job, so was hoping to use those skills to contribute. 🤷♂️
In case anyone else finds the work I did helpful:
@alxd @Gargron@mastodon.social not acceptable
@alxd I apologize for the disappointment this has caused. With a due release, there was no time for me to fix it or wait for you to fix it, and it didn't make sense to delay the release just for this feature.
Sometimes PRs that cause unforeseen issues are reverted to ensure a more well-rounded release. The feature was live on mastodon.social for 20 days and as you can imagine I heard feedback about them and observed how they break given certain inputs, data which was not available during review
Thank you for clarifying.
Why not let me know to fix it after the release though? Its been over a month since the revert, I could prepare that for 2.8.
Its enough to tell me what doesnt work.
Any chance for a detailed description what was wrong? I will still gladly fix it, if I only know more than "Issues with line breaks / clutter".
Is there a problem with longer names? Special characters? What was the feedback you received?